Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use thegraph-headers graph-attestation http header #1007

Merged

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Dec 9, 2024

This pull request includes several changes aimed at improving the handling of HTTP headers and simplifying the codebase. The most significant changes include the addition of a new crate for headers, removing the attestation_header module, and updating how headers are added to HTTP responses.

Improvements to header handling:

  • Cargo.toml: Added the thegraph-headers crate with the attestation feature.
  • src/client_query.rs: Updated imports to use thegraph_headers for GraphAttestation and HttpBuilderExt. Removed the attestation_header module import. [1] [2]

Codebase simplification:

Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
@LNSD LNSD requested a review from Theodus December 9, 2024 16:10
@LNSD LNSD self-assigned this Dec 9, 2024
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LNSD LNSD merged commit 85ef06e into main Dec 9, 2024
2 checks passed
@LNSD LNSD deleted the lnsd/chore-use-thegraph-headers-graph-attestation-header branch December 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants